Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11 Update dependencies. Add jscs configuration file similar to other enb-packages. Make code changes #12

Merged
merged 2 commits into from
Sep 8, 2015

Conversation

tormozz48
Copy link
Contributor

Resolve #11

  • Update dependencies and dev-dependencies
  • Remove enb-validate-code package
  • Add actual jscs configuration file
  • Make code changes to make code valid against new jscs configuration

@blond @j0tunn
Please review it

return Array.isArray(content)
? getFromLastLine_(content)
: getFromText_(content);
return Array.isArray(content) ? getFromLastLine_(content) : getFromText_(content);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

кто ругается на эту строчку? jscs? или jshint? Имеет смысл добавить правило, чтобы так было возможно писать. В jshint это laxbreak

@tormozz48
Copy link
Contributor Author

Ругался jscs. Нашел проблемную опцию requireOperatorBeforeLineBreak и отключил ее

@tormozz48
Copy link
Contributor Author

🆙

@j0tunn
Copy link
Contributor

j0tunn commented Sep 8, 2015

🆗

tormozz48 added a commit that referenced this pull request Sep 8, 2015
#11 Update dependencies. Add jscs configuration file similar to other enb-packages. Make code changes
@tormozz48 tormozz48 merged commit f9ea29f into master Sep 8, 2015
@tormozz48 tormozz48 removed the review label Sep 8, 2015
@tormozz48 tormozz48 deleted the issue-11 branch September 8, 2015 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants